Nosame for 3 players

handsnfeetface

handsnfeetface

Member
I seem to be having a bit of trouble getting nosame to work properly in my Mod.  Actually, it's just when 3 players are implemented.  It states it's function for player 1 and 2 in the manual, but doesn't mention anything about 3 and 4. Has it been implemented beyond 2 players, yet, or am I doing something incorrectly?
 
Sort by date Sort by votes
I set up two identical sets to test it out.  One has two players and the other has three.  It works as intended for the two player mode, but with three player mode you can select the same characters.  I'm using build 4432 if that makes a difference.
 
Upvote 0 Downvote
I just checked the engine logic for nosame, and there's really no way it could work for a certain number of players and not all of them. As written, it just loops over each player until reaching the max allowed while looking for identical models. The actual number of players is irrelevant.

Code: 
s_model *nextplayermodeln(s_model *current, int p)
{
    int i;
    s_set_entry *set = levelsets + current_set;
    s_model *model = nextplayermodel(current);
    if(set->nosame & 1)
    {
        for(i = 0; model && i < set->maxplayers; i++)
        {
            if(i != p && stricmp(model->name, player[i].name) == 0)
            {
                model = nextplayermodel(model);
            }
        }
    }
    return model;
}

We might have to see some of your module to know what is going wrong.
 
Upvote 0 Downvote
handsnfeetface said:
I set up two identical sets to test it out.  One has two players and the other has three.  It works as intended for the two player mode, but with three player mode you can select the same characters.  I'm using build 4432 if that makes a difference.
Click to expand...

Hi! This is an old bug in the build 4432 but White Dragon solved this in the build 6330. SOR2X uses 4 players with nosame and works fine
 
Upvote 0 Downvote
Kratus said:
Hi! This is an old bug in the build 4432 but White Dragon solved this in the build 6330. SOR2X uses 4 players with nosame and works fine
Click to expand...

Kratus Yeah,.. Totally :

Nosame 0 1 - 2 players test - Still can choose same color BUG:


Nosame 1 1 - 4 players test - With more than 2 players, player 3 or player 4 still can coose the same player BUG! This is only happening when switch to previous player by pressing the "left button":


So yeah,  you guys read the forum better and also test your games better before you will suggest to other people of what is "supposed" to be fixed or not  ;)

By the way, the tests are made with the OpenBOR 6330 you are using and suggested.
 
Upvote 0 Downvote
magggas  this type of commentary is not necessary:
So yeah,  you guys read the forum better and also test your games better before you will suggest to other people of what is "supposed" to be fixed or no
Click to expand...
Like...AT ALL.

I know you are trying to help. But your tone is not that cool - its kinda hostile in fact.
 
Upvote 0 Downvote
O Ilusionista said:
I know you are trying to help. But your tone is not that cool - its kinda hostile in fact.
Click to expand...

Oh come on guys, of course i don't have anything against Kratus and i also was not mean to be rude or something. Yet the thing is still that we all should test things first and also read the forum before we post any missinformations about the engine.

Now that i still have to explaine myselfe on such situations just because you guys are focusing on wrong things instead the real issues.. well this is starting to getting old guys, come one..! And you know what, besides me, many other people have told me that they are not as active here anymore just because of this behavior you guys having in such cases or in general some times. Just saiyng.
 
Upvote 0 Downvote
magggas said:
Kratus said:
Hi! This is an old bug in the build 4432 but White Dragon solved this in the build 6330. SOR2X uses 4 players with nosame and works fine
Click to expand...

Kratus Yeah,.. Totally :

Nosame 0 1 - 2 players test - Still can choose same color BUG:

Nosame 1 1 - 4 players test - With more than 2 players, player 3 or player 4 still can coose the same player BUG! This is only happening when switch to previous player by pressing the "left button":

So yeah,  you guys read the forum better and also test your games better before you will suggest to other people of what is "supposed" to be fixed or not  ;)

By the way, the tests are made with the OpenBOR 6330 you are using and suggested.
Click to expand...

SOR2X TEST VER 1.7 BETA, OPENBOR BUILD 6330

NOSAME 0 1
https://www.youtube.com/watch?v=zU4XuoTk9tc

NOSAME 1 1
https://www.youtube.com/watch?v=5q1h6wYsxfk
 
Upvote 0 Downvote
Kratus The test run with 4 players was not acurate because you was moving both player 3 and 4 in same time with the same Left/right buttons. So you have to set different Left/Right buttons for player 3 and for player 4 and then retest this one. Because otherwise your last run with 4 players was wrongly made and proves nothing as it is actually.
 
Upvote 0 Downvote
magggas said:
Kratus The test run with 4 players was not acurate because you was moving both player 3 and 4 in same time with the same Left/right buttons. So you have to set different Left/Right buttons for player 3 and for player 4 and then retest this one. Because otherwise your last run with 4 players was wrongly made and proves nothing as it is actually.
Click to expand...

SOR2X VER. 1.7 BETA - NOSAME 1 1 TEST, OPENBOR BUILD 6330, INDIVIDUAL JOYSTICKS

https://www.youtube.com/watch?v=y6LEzyX51c0
 
Upvote 0 Downvote
Kratus said:
..
SOR2X VER. 1.7 BETA - NOSAME 1 1 TEST, OPENBOR BUILD 6330, INDIVIDUAL JOYSTICKS
..
Click to expand...

Okay nice. Now since it's not possible for us to distinguish this in the video i do have to ask. On this test did you try to switch specifically the player 3 or player 4 by pressing the Left button instead the Right?(because only this case is causing the issue)

Oh and by the way, don't get me wrong, this is not about "you should prove" anything to me. We both are trying to give to the topic the most clear and accurate answer for those who care and that's it.
 
Upvote 0 Downvote
magggas said:
Kratus said:
..
SOR2X VER. 1.7 BETA - NOSAME 1 1 TEST, OPENBOR BUILD 6330, INDIVIDUAL JOYSTICKS
..
Click to expand...

Okay nice. Now since it's not possible for us to distinguish this in the video i do have to ask. On this test did you try to switch specifically the player 3 or player 4 by pressing the Left button instead the Right?(because only this case is causing the issue)
Click to expand...

Yes, the first direction pressed in all tests is always "left". I see that you are using an old version of SOR2X, I suggest you to check your OpenBOR.exe version in this case
 
Upvote 0 Downvote
magggas said:
O Ilusionista said:
I know you are trying to help. But your tone is not that cool - its kinda hostile in fact.
Click to expand...

Oh come on guys, of course i don't have anything against Kratus and i also was not mean to be rude or something. Yet the thing is still that we all should test things first and also read the forum before we post any missinformations about the engine.

Now that i still have to explaine myselfe on such situations just because you guys are focusing on wrong things instead the real issues.. well this is starting to getting old guys, come one..! And you know what, besides me, many other people have told me that they are not as active here anymore just because of this behavior you guys having in such cases or in general some times. Just saiyng.
Click to expand...

Magggas... I really don't want to get into an argument with you. By several reasons - some good, some bad.
I already watched this movie before and I know how it ends.
So I will skip this subject. Really.

About the error, we have a Github for that. It would be cool when someone founds an error if the person post at GitHub, like I do for example.
https://github.com/DCurrent/openbor/issues

This is way easier for the devs to track.
 
Upvote 0 Downvote
Kratus said:
Yes, the first direction pressed in all tests is always "left". I see that you are using an old version of SOR2X, I suggest you to check your OpenBOR.exe version in this case
Click to expand...

Ah yeah, that was it. At first i thought that your downloads are using the 6330 since you suggested it, so i did not check this before. Now that i checked the log i see that the version of your game i downloaded and tested was using an older OpenBOR from 2017. So yeah, sorry for the whole confusion and hassle.
 
Upvote 0 Downvote
You must log in or register to reply here.
Back
Top Bottom