Solved ondoattack help

[O Ilusionista]

Hi there.
I am trying to make this work but I am missing something.
I want to make some entities totally imune to ATTACK17 using ondoattack. I know I could use a defense setting, but I need to use ondoattack because I want to nullify the attack completly (no hitfx, no flash, etc)

This is the code I am using

void main()
{
	void self;      // Entity running event
	void other;     // Entity attacking or receiving vs. self.
	int which;      // Attacker or defender event?
	int id_hit_by;  // Entity ID of entity attack hit.
	int id_attack;  // Entity ID of entity that performed attack.

	Type		= getlocalvar("attacktype");// Get attack type
	self        = getlocalvar("self");
	other       = getlocalvar("other");
	which		= getlocalvar("which");
	
	// Is this a defending event?
	if(!which))
	{
	    // IDs are not the same? This is how we prevent repeat
	    // hits from the same attack.
	    hit_by_id   = getentityproperty(self, "hitbyid");
        attack_id   = getlocalvar("attackid");
	
	    if(hit_by_id != attack_id) && (Type=="ATK_NORMAL17")
        {
			changeopenborvariant("lasthitc", 0);
        }				
	}
    
    // Set hit id on self to attack ID for the next cycle.
	changeentityproperty(self, "hitbyid", hit_by_id);
}

What I am missing here?

 

[DCurrent]

What is it doing? Throwing an error? Still taking the hit?

DC

 

[O Ilusionista]

Still taking the hit and dying (the entity has 1 of health).

 

[DCurrent]

Let me get a WIn 7 install I need done going, and then I'll take a closer look.

 

[DCurrent]

Just created a Gist with your code fixed (I hope, lol). I found two problems.

The first is you need to use a constant for the "which" check. This part wasn't a break, but still - always use constants when you can.

The part that actually broke the code is here. Instead of comparing type to an attack type constant, you just had plan text there. Since the attack type is a number and that text was... well text, it will never match. I fixed it and broke the if into parts for you.

Unless I made a typo or missed something else you should be good to go.

DC

 

[O Ilusionista]

Duh, I forgot to add "openborconstant"and the wrong type.
I will test it and report.

Thanks

 

[O Ilusionista]

No good. They damage still happens.
(and yes, the attack is set right on the attacker).

Any clue?

 

[DCurrent]

What version of OpenBOR are you on?

 

[O Ilusionista]

Sorry, I was testing it on my old 4432 build.
But I tried on the most recent build I am testing for some time (6325) and it doesn't works either.

 

[DCurrent]

OK, hitting the road - but I'll look at this closer. I have an idea of what it is, but not sure until I can test further (the constants may not be returning correct values). If so, I'll need to do a patch.

DC

 

[O Ilusionista]

Solved using this tutorial : http://www.chronocrash.com/forum/index.php?topic=4025.0

 

[Bruce]

Solved using this tutorial : ChronoCrash

how come this link you mentioned
doesn't bring me to where the tutorial topic is? It only brings me to the ChronoCrash main forum,
thanks

 

[maxman]

Healing Orb [SOLVED]

Hello again, fellow developers! I'm making a new move for one of my characters: a healing orb spell. Upon casting, the character spawns a healing orb that restores 20 HP upon contact. Instead of dealing with complicated attack types for such effect, i decided to simply make the char to spawn...

chronocrash.com